Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Jun 2, 2022

Need to rebase after merging #194

  • add return type
  • refactor Filter tests

@kenjis kenjis force-pushed the refactor-add-return-type branch from 7dae9ff to db9a17d Compare June 2, 2022 06:53
@kenjis kenjis marked this pull request as draft June 2, 2022 06:53
@kenjis kenjis force-pushed the refactor-add-return-type branch from db9a17d to ef71da7 Compare June 2, 2022 07:08
@kenjis kenjis mentioned this pull request Jun 2, 2022
2 tasks
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't need to re-review after rebase.

@kenjis kenjis force-pushed the refactor-add-return-type branch from ef71da7 to baf204e Compare June 2, 2022 11:17
@kenjis kenjis marked this pull request as ready for review June 2, 2022 11:18
@lonnieezell lonnieezell merged commit ed439e6 into codeigniter4:develop Jun 3, 2022
@kenjis kenjis deleted the refactor-add-return-type branch June 3, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants