Magic link add link back to login#375
Magic link add link back to login#375jlopes90 wants to merge 14 commits intocodeigniter4:developfrom
Conversation
|
Because of "feat: add filter permission and group" the branch is develop. I forget a lot of time to create branch. |
|
This branch has conflicts that must be resolved. $ git fetch upstream
$ git rebase upstream/developResolve conflict, and $ git rebase --continue |
|
Run |
|
Sorry, |
|
I think I already solved it, I used |
…m/jlopes90/shield into magic-link-add-link-back-to-login
backToLogin
|
@jlopes90 , I want you to write a unittest for this PR. shield/tests/Collectors/AuthTest.php Lines 40 to 54 in c48cb81 You can write the test in tests/Controllers/MagicLinkTest.php.eg: public function testHasLinkBackToLogin(): void
{
// test code
}Please do your best, and let me know if you can't. |
|
Unfortunately, I tried to figure it out and I still don't understand how things work. |
It's okay, you'll learn it eventually. In fact, this test is not important for this PR. Look here, it will help you a lot. |
|
@jlopes90, change it: </form>
<p class="text-center"><a href="<?= url_to('login') ?>"><?= lang('Auth.backToLogin') ?></a></p> |
backToLogin
…m/jlopes90/shield into magic-link-add-link-back-to-login
|
oops, wrong duplicate commits |
|
I don't know why you committed the duplicate commits. Please don't use |




No description provided.