Skip to content

fix: validation password #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GeorgKott wants to merge 3 commits into from
Closed

fix: validation password #712

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a515932
fix: validation password has error when email doesn't contain the @ s…
GeorgKott Apr 24, 2023
8234212
fix: validation password has error when email doesn't contain the @ s…
GeorgKott Apr 24, 2023
ba569a7
Merge branch 'develop' into fix_validation_password
GeorgKott Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/Authentication/Passwords/NothingPersonalValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,16 @@ protected function isNotPersonal(string $password, ?User $user): bool
$needles = $this->strip_explode($userName);

// extract local-part and domain parts from email as separate needles
[
$localPart,
$domain,
] = explode('@', $email);
if (str_contains($email, '@')) {
[
$localPart,
$domain,
] = explode('@', $email);
} else {
$localPart = $email;
$domain = null;
}

// might be john.doe@example.com and we want all the needles we can get
$emailParts = $this->strip_explode($localPart);
if (! empty($domain)) {
Expand Down