feat: add support for multiple permissions check for users#791
Merged
kenjis merged 7 commits intocodeigniter4:developfrom Aug 22, 2023
Merged
feat: add support for multiple permissions check for users#791kenjis merged 7 commits intocodeigniter4:developfrom
kenjis merged 7 commits intocodeigniter4:developfrom
Conversation
lonnieezell
approved these changes
Aug 16, 2023
datamweb
reviewed
Aug 17, 2023
datamweb
reviewed
Aug 17, 2023
kenjis
reviewed
Aug 18, 2023
kenjis
reviewed
Aug 21, 2023
Member
|
The implementation looks good. |
Contributor
|
@sammyskills maybe add test also for wildcard case |
Co-authored-by: kenjis <kenji.uui@gmail.com>
8ae0f85 to
6d9e5be
Compare
Contributor
Author
Yes, you are correct @jozefrebjak. I have added that now. |
datamweb
approved these changes
Aug 21, 2023
Collaborator
datamweb
left a comment
There was a problem hiding this comment.
LGTM!
@sammyskills and @jozefrebjak thanks.
kenjis
approved these changes
Aug 22, 2023
Member
|
@sammyskills Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for multiple permissions check for users via the
Authorizabletrait.With this pull request, instead of writing:
we use this: