refactor: update minimum CI4 version to 4.3.5#871
Merged
kenjis merged 2 commits intocodeigniter4:developfrom Oct 3, 2023
Merged
refactor: update minimum CI4 version to 4.3.5#871kenjis merged 2 commits intocodeigniter4:developfrom
kenjis merged 2 commits intocodeigniter4:developfrom
Conversation
datamweb
reviewed
Oct 2, 2023
Collaborator
datamweb
left a comment
There was a problem hiding this comment.
I'm on mobile, but I guess we need a refactor. For example below:
shield/tests/Commands/SetupTest.php
Line 25 in 09a7cf3
e36e4ee to
4c381f4
Compare
Member
Author
|
Removed code for CI 4.2.x or before. |
5 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CI 4.4 is already released, and there are vulnerabilities in prior to 4.3.5.
Checklist: