Skip to content

๐Ÿ›[Fix] ChatBubbleList storybook router ์—๋Ÿฌ fix #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cloud0406 merged 1 commit into from
Feb 6, 2025
Merged

๐Ÿ›[Fix] ChatBubbleList storybook router ์—๋Ÿฌ fix #334

cloud0406 merged 1 commit into from
Feb 6, 2025

Conversation

@cloud0406
Copy link
Contributor

@cloud0406 cloud0406 commented Feb 5, 2025

#๏ธโƒฃ์—ฐ๊ด€๋œ ์ด์Šˆ

ex) #333

๐Ÿ“์ž‘์—… ๋‚ด์šฉ

ChatBubbleLIst storybook ์—๋Ÿฌ ์ˆ˜์ •

ํ•ด๋‹น ์ปดํฌ๋„ŒํŠธ์—์„œ next router ๊ธฐ๋Šฅ์„ ์‚ฌ์šฉํ•˜๊ณ  ์žˆ์ง€๋งŒ, ์Šคํ† ๋ฆฌ๋ถ์€ Next ํ™˜๊ฒฝ์ด ์•„๋‹ˆ๋ฏ€๋กœ ๋ฐœ์ƒํ•˜๋Š” ์—๋Ÿฌ.
์Šคํ† ๋ฆฌ๋ถ์— ๋ชจ์˜ ๋ผ์šฐํ„ฐ ์ ์šฉ

๋ฏธ๋ฆฌ๋ณด๊ธฐ, ์‚ฌ์šฉ๋ฐฉ๋ฒ• ๋ฐ ๊ฒฐ๊ณผ๋ฌผ

image

๊ธฐํƒ€ ์ฐธ๊ณ ์‚ฌํ•ญ

@cloud0406 cloud0406 added the ๐Ÿ› Bug ๋ฒ„๊ทธ๋ฅผ ์ˆ˜์ •ํ•˜๊ธฐ ์œ„ํ•œ ์ด์Šˆ๋‚˜ PR label Feb 5, 2025
@cloud0406 cloud0406 self-assigned this Feb 5, 2025
@cloud0406 cloud0406 linked an issue Feb 5, 2025 that may be closed by this pull request
๐Ÿ› [Bug] ChatBubbleList ์Šคํ† ๋ฆฌ๋ถ ์—๋Ÿฌ #333
Closed
2 tasks
@vercel
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
bookco โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 5, 2025 2:24am

wynter24
wynter24 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@wynter24 wynter24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@cloud0406 cloud0406 merged commit 280d347 into develop Feb 6, 2025
7 of 8 checks passed
@cloud0406 cloud0406 deleted the 333-bug-chatbubblelist-์Šคํ† ๋ฆฌ๋ถ-์—๋Ÿฌ branch February 6, 2025 02:03
wynter24 added a commit that referenced this pull request Feb 7, 2025
@wynter24 @haegu97 @cloud0406
โœจ[Feat] SSR(์„œ๋ฒ„ ์‚ฌ์ด๋“œ ๋ Œ๋”๋ง) ๋ฐฉ์‹์œผ๋กœ ์ดˆ๊ธฐ ๋ฐ์ดํ„ฐ๋ฅผ ๊ฐ€์ ธ์˜ค๊ธฐ #308 (#328)
0666413 
* ์ฑ„ํŒ…์ฐฝ ๋†’์ด ์ง€์ • (#307)

* ํ† ์ŠคํŠธ๊ฐ€ ์‚ฌ๋ผ์ง€์ง€ ์•Š๋Š” ๋ฒ„๊ทธ ์ˆ˜์ • #309 (#311)

* โ™ป๏ธ[Refactor] ํ† ์ŠคํŠธ ๋ฉ”์‹œ์ง€ ์ƒ์ˆ˜๋กœ ๊ด€๋ฆฌ #312 (#314)

* โ™ป๏ธ [Refactor] ํ”„๋กœ๊ทธ๋ ˆ์Šค๋ฐ” ๋„˜์นจ ํ˜„์ƒ ํ•ด๊ฒฐ (#313)

* โ™ป๏ธ[Refactor] ํ”„๋กœ๊ทธ๋ ˆ์Šค๋ฐ” 100% ์•ˆ๋„˜๋„๋ก ์ˆ˜์ •

* โœ…[Test] ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ถ”๊ฐ€

* โœจ[Feat] ssr๋กœ ๋ฐ์ดํ„ฐ fetching #308

* โœจ[Feat] ssr๋กœ fetching ํ•œ ๋ฐ์ดํ„ฐ๋ฅผ useQuery ์ดˆ๊ธฐ๋ฐ์ดํ„ฐ๋กœ ์„ค์ • #308

* โœจ[Feat] srr๋กœ data fetching ํ›„ csr๋กœ data fetching ์ž‘์—… ์ค‘ #308

* ๏ฟฝ๐Ÿ“[Docs] ๋ฆฌ๋“œ๋ฏธ ํฌ๋งท ์ ์šฉ (#319)

* ๏ฟฝ๐Ÿ“[Docs] ๋ฆฌ๋“œ๋ฏธ ํฌ๋งท ์ ์šฉ

* ๋ฆฌ๋“œ๋ฏธ ์—…๋ฐ์ดํŠธ

* โœจ[Feat] ssr๋กœ ๊ฐ€์ ธ์˜จ ๋ฐ์ดํ„ฐ๋กœ ๋ Œ๋”๋ง #308

* โœจ[Feat] ssr๋กœ ๋ฐ์ดํ„ฐ fetching #308

* โœจ[Feat] ssr๋กœ fetching ํ•œ ๋ฐ์ดํ„ฐ๋ฅผ useQuery ์ดˆ๊ธฐ๋ฐ์ดํ„ฐ๋กœ ์„ค์ • #308

* โœจ[Feat] srr๋กœ data fetching ํ›„ csr๋กœ data fetching ์ž‘์—… ์ค‘ #308

* โœจ[Feat] ssr๋กœ ๊ฐ€์ ธ์˜จ ๋ฐ์ดํ„ฐ๋กœ ๋ Œ๋”๋ง #308

* ๐Ÿ’„[Design] ๋ชจ์ž„ ์นด๋“œ size=100์œผ๋กœ ์š”์ฒญ #308

* โœ…[Test] fetchBookClub ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ #308

* ๋กœ๊ทธ์ธ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ถ”๊ฐ€ #317 (#318)

* โœ…[Test] useBookClubList ํ›… ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ (์ฟผ๋ฆฌํ‚ค๋กœ ๋ฐ์ดํ„ฐ ๊ฐ€์ ธ์˜ค๊ธฐ ๊ฒ€์ฆ) #308

* โœจ[Feat] ssr๋กœ ๋ฐ์ดํ„ฐ fetching #308

* โœจ[Feat] ssr๋กœ fetching ํ•œ ๋ฐ์ดํ„ฐ๋ฅผ useQuery ์ดˆ๊ธฐ๋ฐ์ดํ„ฐ๋กœ ์„ค์ • #308

* โœจ[Feat] srr๋กœ data fetching ํ›„ csr๋กœ data fetching ์ž‘์—… ์ค‘ #308

* โœจ[Feat] ssr๋กœ ๊ฐ€์ ธ์˜จ ๋ฐ์ดํ„ฐ๋กœ ๋ Œ๋”๋ง #308

* โœจ[Feat] srr๋กœ data fetching ํ›„ csr๋กœ data fetching ์ž‘์—… ์ค‘ #308

* โœจ[Feat] ssr๋กœ ๊ฐ€์ ธ์˜จ ๋ฐ์ดํ„ฐ๋กœ ๋ Œ๋”๋ง #308

* ๐Ÿ’„[Design] ๋ชจ์ž„ ์นด๋“œ size=100์œผ๋กœ ์š”์ฒญ #308

* โœ…[Test] fetchBookClub ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ #308

* โœ…[Test] useBookClubList ํ›… ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ (์ฟผ๋ฆฌํ‚ค๋กœ ๋ฐ์ดํ„ฐ ๊ฐ€์ ธ์˜ค๊ธฐ ๊ฒ€์ฆ) #308

* ๐Ÿ›[Fix] SSR ํ™˜๊ฒฝ์—์„œ ์„œ๋ฒ„ ํ™˜๊ฒฝ๋ณ€์ˆ˜(API_URL) ๋ˆ„๋ฝ ๋ฌธ์ œ ํ•ด๊ฒฐ #308

* ๐Ÿ’ฌ[Comment] ์ฃผ์„ ์ถ”๊ฐ€ #308

* โœ…[Test] ํ™˜๊ฒฝ ๋ณ€์ˆ˜ ์—๋Ÿฌ ํ™•์ธ #308

* โœ…[Test] ํ™˜๊ฒฝ ๋ณ€์ˆ˜ ์—๋Ÿฌ ํ™•์ธ #308

* โ™ป๏ธ[Refactor] ํ™˜๊ฒฝ ๋ณ€์ˆ˜ ์ฃผ์†Œ๋กœ ์ˆ˜์ • #308

* ๐Ÿ“ฆ[Chore] next.config env ์„ค์ • #308

* ๐Ÿ“ฆ[Chore] CI ํ™˜๊ฒฝ์„ค์ •: NEXT_PUBLIC_API_URL ์ „๋‹ฌ ์„ค์ • ์ถ”๊ฐ€ #308

* ๐Ÿ’ฌ[Comment] ํ™˜๊ฒฝ ๋ณ€์ˆ˜ test ์ฃผ์„ ์ œ๊ฑฐ #308

* โ™ป๏ธ[Refactor] fetchBookClub ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ๊ณตํ†ต mockBookClubs ์‚ฌ์šฉ #308

* โ™ป๏ธ[Refactor] fetchBookClubs ์—๋Ÿฌ ๊ฐœ๋ฐœ ํ™˜๊ฒฝ์—์„œ๋งŒ ๋กœ๊ทธ ์ถœ๋ ฅ #308

* ๐Ÿ”ฅ[Remove] ๋ถˆํ•„์š”ํ•œ feature/bookclub/api ์‚ญ์ œ #308

* โ™ป๏ธ[Refactor] initialData ๋ฐฉ์‹ ๋Œ€์‹  prefetchQuery๋กœ ์„œ๋ฒ„์—์„œ ๋ฐ์ดํ„ฐ ๊ฐ€์ ธ์˜ค๊ธฐ #308

* โ™ป๏ธ[Refactor] ์ฐœํ•˜๊ธฐ ํ›„ mutate๋˜๋Š” ๋ชจ์ž„ ๋ชฉ๋ก์˜ ์ฟผ๋ฆฌํ‚ค ๋ณ€๊ฒฝ #308

* โœ…[Test] fetchBookClubs ํ•จ์ˆ˜ ์ˆ˜์ •์— ๋”ฐ๋ฅธ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์—…๋ฐ์ดํŠธ #308

* ๐Ÿ›[Test] Storybook์—์„œ useRouter Mockingํ•˜์—ฌ ์˜ค๋ฅ˜ ํ•ด๊ฒฐ #308

* ๐Ÿ›[Test] Storybook์—์„œ useRouter Mocking ์ฝ”๋“œ ์ œ๊ฑฐ๊ฑฐ #308

* ๐Ÿ›[Fix] storybook router ์—๋Ÿฌ fix (#334)

---------

Co-authored-by: Sungu Kim <108677235+haegu97@users.noreply.github.com>
Co-authored-by: cloud0406 <32586926+cloud0406@users.noreply.github.com>
Co-authored-by: Jeongho Kim <cloud0406@naver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wynter24 wynter24 wynter24 approved these changes

@sunnwave sunnwave sunnwave approved these changes

@haegu97 haegu97 Awaiting requested review from haegu97

Assignees

@cloud0406 cloud0406

Labels

๐Ÿ› Bug ๋ฒ„๊ทธ๋ฅผ ์ˆ˜์ •ํ•˜๊ธฐ ์œ„ํ•œ ์ด์Šˆ๋‚˜ PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

๐Ÿ› [Bug] ChatBubbleList ์Šคํ† ๋ฆฌ๋ถ ์—๋Ÿฌ

4 participants

@cloud0406 @wynter24 @sunnwave