Skip to content

Comments

The gradlew/mvnw path must be made absolute#111

Merged
rahlk merged 3 commits into1.X.Xfrom
make-wrapper-paths-absolute
Feb 11, 2025
Merged

The gradlew/mvnw path must be made absolute#111
rahlk merged 3 commits into1.X.Xfrom
make-wrapper-paths-absolute

Conversation

@rahlk
Copy link
Collaborator

@rahlk rahlk commented Feb 8, 2025

Motivation and Context

The gradlew and mvnw paths were not absolute. This resulted in FileNotFoundException when the user gave --input path/to/application instead of --input $HOME/.../absolute/path/to/application

How Has This Been Tested?

Few line changes, no additional tests need. Passes all regression tests.

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the Codellm-Devkit Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

N/A

Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
@rahlk rahlk requested a review from sinha108 February 8, 2025 21:44
@rahlk rahlk added the bug Something isn't working label Feb 8, 2025
@rahlk
Copy link
Collaborator Author

rahlk commented Feb 11, 2025

Bump patch version

@rahlk rahlk merged commit 34387ac into 1.X.X Feb 11, 2025
@rahlk rahlk deleted the make-wrapper-paths-absolute branch February 12, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants