Skip to content

Fix issue 105: Removed unused parameter issue #105 #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rangeetpan merged 1 commit into from
Feb 20, 2025
Merged

Fix issue 105: Removed unused parameter issue #105 #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cldk/analysis/java/codeanalyzer/codeanalyzer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ def _generate_call_graph(self, using_symbol_table) -> DiGraph:
"type": jge.type,
"weight": jge.weight,
"calling_lines": (
tsu.get_calling_lines(jge.source.method.code, jge.target.method.signature, jge.target.method.is_constructor)
tsu.get_calling_lines(jge.source.method.code, jge.target.method.signature)
if not jge.source.method.is_implicit or not jge.target.method.is_implicit
else []
),
Expand Down
4 changes: 2 additions & 2 deletions tests/analysis/java/test_java_sitter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,14 +287,14 @@ def test_get_calling_lines():
}
"""
# test where call is found
calling_lines = java_sitter.get_calling_lines(source_method_code, "hasNext", False)
calling_lines = java_sitter.get_calling_lines(source_method_code, "hasNext")
assert calling_lines is not None
assert isinstance(calling_lines, List)
assert len(calling_lines) == 1
assert calling_lines[0] == 7

# test where call is not found
calling_lines = java_sitter.get_calling_lines(source_method_code, "foo", False)
calling_lines = java_sitter.get_calling_lines(source_method_code, "foo")
assert calling_lines is not None
assert isinstance(calling_lines, List)
assert len(calling_lines) == 0
Expand Down