Conversation
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
…a superclass if Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
codeanalyzer v2.1codeanalyzer v2.1.0+
rahlk
commented
Feb 21, 2025
Signed-off-by: John Rofrano <johnnyroy@johnrofrano.com>
rofrano
approved these changes
Feb 21, 2025
Collaborator
rofrano
left a comment
There was a problem hiding this comment.
Looks good. I increased the code coverage minimum in our Makefile to 70% since we ave now surpassed that. Great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The failing test cases were caused by incorrect handling of
analysis.json(which had changed since version 2.0.0 of codeanalyzer). Further, there were some nagging bugs on cyclicNotImplementedError, issues with super classes inTreeSitteretc.How Has This Been Tested?
The changes were tested by:
Breaking Changes
No breaking changes. The fixes ensure correctness without modifying existing API contracts or requiring configuration changes.
Types of changes
Checklist
Additional context
Fixed some bugs where treesitter fails to identify a superclass if
public class A extends B<C> { ... }