Avoid re-composition if selection is non-empty, or on double-tap#7008
Open
mihailik wants to merge 1 commit intocodemirror:masterfrom
Open
Avoid re-composition if selection is non-empty, or on double-tap#7008mihailik wants to merge 1 commit intocodemirror:masterfrom
mihailik wants to merge 1 commit intocodemirror:masterfrom
Conversation
Kiuhng32
approved these changes
May 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently on mobile/contentEditable selection is fragile: as you double-tap or tap-drag the editor often refuses and reset selection back.
That happens because CM bails out of native 'composition', and re-renders current line. Redrawing DOM invalidates browser's native selection.
This PR relaxes this composition bailout in 2 cases:
Not only bailing out of composition in those cases is unlikely to change anything, CM's internal state will be properly updated anyway, as a result of the underlying action: changing selection.