feat: makes polling interval configurable#13
Merged
zvikagart merged 3 commits intocodeocean:mainfrom Oct 15, 2024
Merged
Conversation
zvikagart
requested changes
Oct 14, 2024
src/codeocean/computation.py
Outdated
| """ | ||
| Polls the given computation until it reaches the 'Completed' or 'Failed' state. | ||
| """ | ||
| assert polling_interval >= 5, "polling_interval should be greater than or equal to 5" |
Contributor
There was a problem hiding this comment.
Raising a ValueError is preferable over assertions. The latter is more for debugging.
zvikagart
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
5as the default to be backwards compatibleassertso users can't decrease the interval below5