feat(ses/domain): cloudwatch metrics and dashboard widgets#75
Merged
mskrajnowski merged 11 commits intomasterfrom May 11, 2020
Merged
feat(ses/domain): cloudwatch metrics and dashboard widgets#75mskrajnowski merged 11 commits intomasterfrom
mskrajnowski merged 11 commits intomasterfrom
Conversation
8 tasks
karwer
approved these changes
May 7, 2020
| } | ||
|
|
||
| metrics_count = { | ||
| sent = { name = "Send", label = "Sent", color = local.colors.grey } |
Contributor
There was a problem hiding this comment.
Too few colors ;) I understand that this is not a problem - they will not be presented in the same widget?
Collaborator
Author
There was a problem hiding this comment.
I'm using grey to signify the desired/expected values, in this case sent is the desired value for the delivered metric, so that's the logic behind making sent grey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ses/domainmetricsses/domaindashboard widgetsExample dashboard:
Related to #43