feat: add and handle diff_opts.on_unsaved_changes option#125
Open
derethil wants to merge 5 commits intocoder:mainfrom
Open
feat: add and handle diff_opts.on_unsaved_changes option#125derethil wants to merge 5 commits intocoder:mainfrom
derethil wants to merge 5 commits intocoder:mainfrom
Conversation
6d17378 to
bfb9a4d
Compare
Author
|
Changes pushed up in the latest commits - great idea on the discard warning, thanks for that suggestion. |
6197133 to
cfb9067
Compare
cfb9067 to
dea8110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Graceful Dirty Buffer Handling for Diff Operations
This PR adds the ability to gracefully handle unsaved changes when creating diffs. This has two behaviors to choose from:
error(default): Throws an error when attempting to create a diff with unsaved changes. This is unchanged from the existing behavior.discard: Automatically discards unsaved buffer changes by reloading the buffer from disk before creating the diff.The implementation includes:
diff_opts.on_unsaved_changesconfiguration option with validationdiscard_buffer_changes()function that safely reloads buffers from diskThis makes it easier to work with diffs when files have unsaved changes, allowing you to choose between safety or convenience based on your workflow preferences.