Fix terminal process leak when closing the window. #2723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
approved these changes
Feb 22, 2021
Member
code-asher
left a comment
code-asher
left a comment
There was a problem hiding this comment.
Thank you for the fix and the detailed explanation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
this.process.dispose();beforethis.process.shutdown(true);sets a flag_isDisposedto true.This causes the
_kill()procedure to exit early essentially makingthis.process.shutdown(true)a no op.It's necessary to await on the shutdown because _kill() is an async function. Otherwise
_isDisposedwill be set to true before actually killing the process regardless of the call order ofdisposeandshutdown.Impact: Closing the session in the browser should now kill long running processes such as filesystem watchers or services started in the terminal.