Skip to content

Implement missing terminal method #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jsjoeio merged 1 commit into from
Mar 10, 2021
Merged

Implement missing terminal method #2857

jsjoeio merged 1 commit into from
Mar 10, 2021

Conversation

@code-asher
Copy link
Member

@code-asher code-asher commented Mar 10, 2021

I missed this one during the 1.53 update.

@code-asher code-asher requested a review from a team as a code owner March 10, 2021 19:16
jsjoeio
jsjoeio approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 🚢

@jsjoeio jsjoeio added this to the v3.9.2 milestone Mar 10, 2021
@jsjoeio jsjoeio merged commit 69a3e7f into main Mar 10, 2021
@jsjoeio jsjoeio deleted the terminal-missing-func branch March 10, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jsjoeio jsjoeio jsjoeio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.9.2

Development

Successfully merging this pull request may close these issues.

2 participants

@code-asher @jsjoeio