Skip to content

docs(termux): add workaround for Android backspace issue#3251

Merged
repo-ranger[bot] merged 3 commits intomainfrom
jsjoeio/document-android-issue
Apr 28, 2021
Merged

docs(termux): add workaround for Android backspace issue#3251
repo-ranger[bot] merged 3 commits intomainfrom
jsjoeio/document-android-issue

Conversation

@jsjoeio
Copy link
Copy Markdown
Contributor

@jsjoeio jsjoeio commented Apr 28, 2021

This PR adds a new doc called termux.md and documents an issue with the backspace key on Android.

Fixes #3079

@jsjoeio jsjoeio added the docs Documentation related label Apr 28, 2021
@jsjoeio jsjoeio added this to the v3.9.4 milestone Apr 28, 2021
@jsjoeio jsjoeio self-assigned this Apr 28, 2021
@jsjoeio jsjoeio requested a review from a team as a code owner April 28, 2021 20:50
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 28, 2021 •
edited
Loading

Codecov Report

Merging #3251 (79d8e4b) into main (ad6a774) will not change coverage.
The diff coverage is n/a.

❗ Current head 79d8e4b differs from pull request most recent head c16845b. Consider uploading reports for the commit c16845b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3251   +/-   ##
=======================================
  Coverage   46.90%   46.90%           
=======================================
  Files          23       23           
  Lines        1196     1196           
  Branches      237      237           
=======================================
  Hits          561      561           
  Misses        451      451           
  Partials      184      184

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad6a774...c16845b. Read the comment docs.

jawnsy
jawnsy approved these changes Apr 28, 2021
View reviewed changes
ci/dev/fmt.sh
doctoc --title '# Maintaining' docs/MAINTAINING.md >/dev/null
doctoc --title '# Contributor Covenant Code of Conduct' docs/CODE_OF_CONDUCT.md >/dev/null
doctoc --title '# iPad' docs/ipad.md >/dev/null
doctoc --title '# Termux' docs/termux.md >/dev/null
Copy link
Copy Markdown

@jawnsy jawnsy Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to your change, I'm just curious why --title is needed with these, I thought it would just read the h1/# already in the file?

Copy link
Copy Markdown
Contributor Author

@jsjoeio jsjoeio Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol honestly...i don't know the answer to that 🤷‍♂️

maybe @code-asher has historical context

it does seem like there could be a better way to do this though...

Copy link
Copy Markdown

@jawnsy jawnsy Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No big deal, I imagine that we can tackle that sort of clean up when we make a nice doc site :)

@jsjoeio jsjoeio force-pushed the jsjoeio/document-android-issue branch from 9505244 to c16845b Compare April 28, 2021 21:21
@repo-ranger repo-ranger bot merged commit 9722301 into main Apr 28, 2021
@repo-ranger repo-ranger bot deleted the jsjoeio/document-android-issue branch April 28, 2021 22:28
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jawnsy jawnsy jawnsy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jsjoeio jsjoeio

Labels

chore Related to maintenance or clean up docs Documentation related

Projects

None yet

Milestone

v3.10.0

Development

Successfully merging this pull request may close these issues.

Document Android backspace issue

2 participants

@jsjoeio @jawnsy