docs: fix confusing sentence in pull requests section#3460
docs: fix confusing sentence in pull requests section#3460jsjoeio merged 8 commits intocoder:mainfrom shiv-tyagi:grammer-fix
Conversation
|
Thanks for making your first contribution! 🙂 |
|
Thanks for fixing this! @shiv-tyagi 🎉 We would love to make sure you get credit in the next release. Do you mind updating the |
Codecov Report
@@ Coverage Diff @@
## main #3460 +/- ##
=======================================
Coverage 59.21% 59.21%
=======================================
Files 35 35
Lines 1709 1709
Branches 379 379
=======================================
Hits 1012 1012
Misses 559 559
Partials 138 138 Continue to review full report at Codecov.
|
|
It's my pleasure to contribute to the community. As I am a complete beginner to open source, can you guide me a bit about how to update CHANGELOG? |
|
Sure thing! The
(P.S. planning to add more docs about updating the |
|
I have committed the changes in changelog. Please review the same. If anything needs to be changed, please let me know. |
jsjoeio
left a comment
There was a problem hiding this comment.
Looks great! Thanks again @shiv-tyagi 🎉
|
Apologies @shiv-tyagi - can you please run |
|
I have allowed edits from maintainers. I can't figure it out what 'yarn fmt' and how to do this. It would be great if you elaborate a bit more @jsjoeio . |
I figured it out. I installed yarn locally and then I did run 'yarn fmt'. It made some changes in CHANGELOG.md . I hope I did it correctly @jsjoeio . |
Head branch was pushed to by a user without write access
|
Hooray! (Sorry I should have elaborated). Glad you got it though! I think it should be good then! |
This PR fixes a sentence in Pull request section which was less understandable on the first go.
Checklist
CHANGELOG.md