fix(publish): update cdrci fork in brew-bump.sh#3468
Merged
repo-ranger[bot] merged 2 commits intomainfrom Jun 3, 2021
Merged
Conversation
32409a7 to
6305d5e
Compare
jsjoeio
commented
May 25, 2021
2 tasks
2 tasks
Codecov Report
@@ Coverage Diff @@
## main #3468 +/- ##
=======================================
Coverage 59.21% 59.21%
=======================================
Files 35 35
Lines 1709 1709
Branches 379 379
=======================================
Hits 1012 1012
Misses 559 559
Partials 138 138 Continue to review full report at Codecov.
|
acb992a to
1c39518
Compare
Contributor
Author
|
@code-asher ready for a second review |
code-asher
approved these changes
Jun 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the homebrew
brew-bump.shstep which runs when we publish a new release.Additional Context
Problem
When we publish a new release, we run a script to bump the formula for code-server on homebrew. The script works using
cdrci's GitHub token (secret in repo) so that the PR comes from them and not a maintainer.The problem is
bump-formula-pruses the user'shomebrew-corefork.This means we need to ensure the fork is up-to-date.
To do that, we need to pull the remote and push the changes to the fork before running
bump-formula-pr.We tried to see if it would "just work" by pulling and pushing, but the push command asks for a username and password.
Solution
You can get around this with
--all. We found this solution here.Changes
brew-bump.shScreenshots
Tested locally and this new approach should work.

Checklist
CHANGELOG.mdFixes #3444