docs(helm): add required env for docker-in-docker#5045
Merged
jsjoeio merged 2 commits intocoder:mainfrom Mar 30, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5045 +/- ##
=======================================
Coverage 71.30% 71.30%
=======================================
Files 30 30
Lines 1683 1683
Branches 373 373
=======================================
Hits 1200 1200
Misses 413 413
Partials 70 70 Continue to review full report at Codecov.
|
TinLe
pushed a commit
to TinLe/code-server
that referenced
this pull request
Apr 23, 2022
Co-authored-by: Joe Previte <jjprevite@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #199
Hi, I see there's an example of docker in docker in
extraContainersbut in order to use it, you need to set
DOCKER_HOSTin code-server tooI think it a good idea to add more since we already had dind in
extraContainersWorking in my RKE cluster v1.21.10