fix: run code-server as the appropriate user#1
Merged
DanielleMaywood merged 3 commits intomainfrom Apr 8, 2025
Merged
Conversation
Rather than run code-server as root, we instead run it as the appropriate user.
mafredri
reviewed
Apr 8, 2025
src/code-server/install.sh
Outdated
| set -e | ||
|
|
||
| code-server --bind-addr "$HOST:$PORT" \$ARGS | ||
| runuser -l $_REMOTE_USER -c 'code-server --bind-addr "$HOST:$PORT" \$ARGS' |
Member
There was a problem hiding this comment.
Is there anything that guarantees runuser is present? I know it's present in both Debian and Ubuntu, but for instance containers like Alpine and Fedora don't have it.
Collaborator
Author
There was a problem hiding this comment.
That's a good point, I've switched to su instead.
Some linux distributions do not ship with runuser
mafredri
approved these changes
Apr 8, 2025
| set -e | ||
|
|
||
| code-server --bind-addr "$HOST:$PORT" \$ARGS | ||
| su $_REMOTE_USER -c 'code-server --bind-addr "$HOST:$PORT" \$ARGS' |
Member
There was a problem hiding this comment.
Sanity check: Is this remote user env always set?
Collaborator
Author
There was a problem hiding this comment.
According to the docs it should be https://containers.dev/implementors/features/#user-env-var
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than run code-server as root, we instead run it as the appropriate user.