Skip to content

Conversation

@BrunoQuaresma
Copy link
Contributor

Closes #159

@BrunoQuaresma BrunoQuaresma self-assigned this Apr 30, 2024
@johnstcn
Copy link
Member

johnstcn commented May 1, 2024

I think this might also be a good place to add a check in the integration tests that the docker config.json was removed, something like this might work:

		statOutput := execContainer(t, ctr, "stat "+filepath.Join(envbuilder.MagicDir, "config.json"))
		require.Contains(t, statOutput, "No such file or directory")

@BrunoQuaresma BrunoQuaresma requested a review from johnstcn May 1, 2024 16:07
@BrunoQuaresma BrunoQuaresma merged commit ff220b4 into main May 1, 2024
@BrunoQuaresma BrunoQuaresma deleted the bq/cleanup-warning branch May 1, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warn if clean up does not work when removing Docker config file.

2 participants