feat: prefix env variables with ENVBUILDER #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
reviewed
May 10, 2024
Member
mtojek
left a comment
mtojek
left a comment
There was a problem hiding this comment.
Do you think we need any unit tests here?
Contributor
Author
Yes, I was waiting for some review to see if I was in the right direction. 👍 |
Member
|
Awesome! Looking forward to see some tests 👍 |
johnstcn
reviewed
May 10, 2024
BrunoQuaresma
commented
May 10, 2024
Member
|
just make sure that CI is happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166