🤖 refactor: organize UI tests into product-area subfolders#2389
Merged
Conversation
Move 38 flat UI test files into semantic subfolders aligned with docs product areas: workspaces, compaction, agents, chat, review, tasks, config, layout, git, runtime, gateway. - Drop redundant .integration suffix from all filenames - Normalize verbose prefixes (e.g., workspaceLifecycle → workspaces/lifecycle) - Update all relative imports (files moved one level deeper) - Shared helpers (dom.ts, helpers.ts, harness/, renderReviewPanel.tsx) stay at tests/ui/ root No production code changes. All 35 test suites pass.
ammar-agent
force-pushed
the
tests-rakp
branch
from
85d5009 to
0748283
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reorganize 38 flat UI test files into semantic subfolders aligned with docs product areas. Phase 2 of the integration test restructuring (Phase 1 was IPC tests in #2370).
Background
All 38 UI tests lived in a flat
tests/ui/directory with verbose filenames likeworkspaceLifecycle.integration.test.ts. Finding related tests required scanning every filename. The.integrationsuffix is redundant since being intests/already means "integration test."Implementation
Created 11 subfolders matching documentation product areas:
workspaces/chat/agents/review/tasks/layout/compaction/config/git/gateway/runtime/Shared helpers (
dom.ts,helpers.ts,harness/,renderReviewPanel.tsx) remain attests/ui/root to minimize import churn.All moves used
git mvto preserve history. Relative imports updated (one level deeper:./dom→../dom,../ipc/→../../ipc/, etc.).Validation
TEST_INTEGRATION=1 bun x jest tests/ui)make typecheckcleanmake lintcleanmake fmt-checkclean (2 files auto-formatted bymake fmt)tests/ui/)Note: 3
.test.tsxfiles aren't discovered by Jest due to pre-existingtestMatchpattern (*.test.tsonly) — not caused by this change.Generated with
mux• Model:anthropic:claude-opus-4-6• Thinking:xhigh• Cost:$14.99