🤖 fix: add gpt-5.3-codex-spark model override#2395
Open
ammar-agent wants to merge 1 commit intomainfrom
Open
Conversation
Add a models-extra override for gpt-5.3-codex-spark using the newly published Codex metadata (128k context and text-only capabilities), and add focused tests for model stats and capability lookup behavior. --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$0.00`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.00 -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a local
models-extra.tsoverride for OpenAI's newly announcedgpt-5.3-codex-sparkmodel so pricing/token accounting and capability checks work before upstreammodels.jsoncatches up.Background
The model appeared after our current upstream model snapshot, and user workflows rely on local override data for cost/context UI and routing metadata.
Implementation
gpt-5.3-codex-sparktosrc/common/utils/tokens/models-extra.ts.supports_vision: false) based on launch details.src/common/utils/tokens/modelStats.test.tssrc/common/utils/ai/modelCapabilities.test.tsValidation
make static-checkbun test src/common/utils/tokens/modelStats.test.ts src/common/utils/ai/modelCapabilities.test.tsRisks
Low. Change is additive and isolated to model metadata lookup paths.
Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$0.00