post build initialization

[teddy-codes]

I have found myself every time rebuilding my sail fork and needing to run either:

• go get
• npm install

Is there a way to have a post-build shell script?

[ammario]

There's a concept for a .sail/on_open file. This is a priority feature for sure.

[nathanpotter]

You should be able to add an ENTRYPOINT to your hat Dockerfile that can do this

[teddy-codes]

That is true. I have not tried this yet.. do you think that an on_open would be better than just adding an ENTRYPOINT?

[nathanpotter]

Not particularly, I think it's probably better to stick with docker idioms when possible

[teddy-codes]

Is the entrypoint overwritten by code-server?

[ammario]

ENTRYPOINT is not the correct idiom. We don't want on_open to be the root command to the container, code-server takes that role.

[nathanpotter]

Ah, I guess I misunderstood how ENTRYPOINT worked, yeah having a .sail/on_open sounds good to me

[ammario]

should be implemented by @nhooyr ... he's most comfortable with the typescript code

[teddy-codes]

Would this be a shell script?

[ammario]

It would be an executable file

[teddy-codes]

I am not understanding this properly then... .sail/on_open would be able to run arbitrary code from the user (or repo owner), correct?

[nhooyr]

I'm not sure why we need this? Wouldn't you just put this in the project docker file?

[teddy-codes]

A start script will not work within the projects Dockerfile because you do not have the files at the time that the image is building. A start script would allow you to have access to the files (package.json, go mod, etc...) allowing you to, on container start, to run go get or npm install. It is a burden to, every time I start a container (or rebuild it) to do this.

Edit:
Also, this would allow you to install specific tooling for a project. In Sail's case, it would be things like gopls and goimports (just tooling)

Maybe spinning up some docker containers that are required for the image as well.

[teddy-codes]

Also, does this belong on the General 1 board?