Conversation
|
Do you guys think it's worth making the script POSIX instead of bash? Would make it uglier but work across more platforms. |
| log "finding latest release" | ||
| local os=$1 | ||
| download https://api.github.com/repos/cdr/sail/releases/latest | | ||
| jq -r ".assets[] |
There was a problem hiding this comment.
I don't think it's a good idea to assume jq is installed.
There was a problem hiding this comment.
That's a fair point. It just makes it so nice and easy 😭
There was a problem hiding this comment.
Jank shell solution:
curl https://api.github.com/repos/cdr/sail/releases/latest | grep "browser_download_url" | grep "linux" | awk -F": " '{print $2}'
There was a problem hiding this comment.
yeah definitely can't use jq...
ammario
left a comment
ammario
left a comment
There was a problem hiding this comment.
This script should be in site/static/install.sh so it's served from sail.dev/install.sh
| log "finding latest release" | ||
| local os=$1 | ||
| download https://api.github.com/repos/cdr/sail/releases/latest | | ||
| jq -r ".assets[] |
There was a problem hiding this comment.
yeah definitely can't use jq...
|
Also should amend docs |
|
@nhooyr isn't bash universal these days? |
|
Yea pretty much, I guess its nbd, lets see if anyone wants a POSIX compliant script after release. |
3 participants
Closes #150