This repository was archived by the owner on Apr 28, 2020. It is now read-only.
Add makefile#241
Merged
deansheather merged 3 commits intocoder:masterfrom Aug 6, 2019
teddy-codes:makefile
Merged
Conversation
Contributor
Author
|
Should I do a quick check within the makefile to ensure that the OS is supported? Also, should I add a GOOS value with the |
Member
|
Probably best to leave the GOOS up to the user as it's an env variable. I don't think it's neccessary to restrict what OS is supported. |
deansheather
suggested changes
Jul 26, 2019
Member
|
Bump |
Contributor
Author
|
Yea, my bad. I have been away and trying to catch up. |
Contributor
Author
|
@deansheather should be good to go now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a makefile that should be used when people want to build from source instead of using the custom script provided.
/cc @deansheather
Edit:
Resolves #240