fix!: add extra validation for start_blocks_login #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
changed the base branch from
main
to
mafredri/fix-docs-and-validation
johnstcn
approved these changes
Feb 9, 2024
Member
johnstcn
left a comment
johnstcn
left a comment
There was a problem hiding this comment.
I'm in favour of this change, as it will surface a misconfiguration to the user as opposed to it just silently not working.
mafredri
force-pushed
the
mafredri/fix-add-extra-start-blocks-login-validation
branch
from
dc08ac6 to
59bcde6
Compare
mafredri
deleted the
mafredri/fix-add-extra-start-blocks-login-validation
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally part of #191 but split out because it is a bit of a breaking change, but hopefully it will help users avoid confusion when one is set without the other and the feature doesn't work.
This guarantee also makes our coder/coder more correct since it's common pratice to only look at
start_blocks_login.