feat: relax error message for number-typed coder parameters #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
changed the title
johnstcn
reviewed
Feb 19, 2024
2 tasks
johnstcn
approved these changes
Feb 19, 2024
johnstcn
approved these changes
Feb 19, 2024
Member
johnstcn
left a comment
johnstcn
left a comment
There was a problem hiding this comment.
LGTM 👍 Up to you if you want to mention {value}, {min}, and {max} in the doc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: coder/coder#12192
Right now, only string-typed parameters can use custom messages. This PR relaxes strict validation rules to support custom errors for number-typed coder parameters.