feat: Expose access_port on coder_workspace to allow for alternative hosts #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hosts This allows our Docker template to use a custom host with the correct port.
bpmct
reviewed
Aug 15, 2022
Member
bpmct
left a comment
bpmct
left a comment
There was a problem hiding this comment.
Does coder server always assume HTTP or HTTPS as an access URL now? Should we add an access_port there too?
Member
Author
|
Nah, this just pulls the access port dynamically from the URL itself. I think it's better to be in the URL, this just allows for situations where you want a custom host, but same port. |
bpmct
approved these changes
Aug 15, 2022
DanielleMaywood
pushed a commit
that referenced
this pull request
Sep 5, 2024
…hosts (#37) This allows our Docker template to use a custom host with the correct port.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows our Docker template to use a custom host with the correct port.