fix: Add custom host for access URL and remove access port #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a host override, which is useful for running Docker containers that need to access the same deployment port, but on `host.docker.internal` as the hostname. It also removes access port, which was released a few days ago in hopes of solving the same problem, but never really did. It doesn't seem likely to be used yet, so it feels safe to remove.
Signed-off-by: Spike Curtis <spike@coder.com>
spikecurtis
approved these changes
Aug 18, 2022
DanielleMaywood
pushed a commit
that referenced
this pull request
Sep 5, 2024
* fix: Add custom host for access URL and remove access port This allows a host override, which is useful for running Docker containers that need to access the same deployment port, but on `host.docker.internal` as the hostname. It also removes access port, which was released a few days ago in hopes of solving the same problem, but never really did. It doesn't seem likely to be used yet, so it feels safe to remove. * Fix access url when host is not provided Signed-off-by: Spike Curtis <spike@coder.com> Signed-off-by: Spike Curtis <spike@coder.com> Co-authored-by: Spike Curtis <spike@coder.com> Co-authored-by: Spike Curtis <spike@spikecurtis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a host override, which is useful for running Docker
containers that need to access the same deployment port, but on
host.docker.internalas the hostname.It also removes access port, which was released a few days ago in hopes of
solving the same problem, but never really did. It doesn't seem likely to
be used yet, so it feels safe to remove.