feat: Add icon to coder_metadata resource #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
If you approve this and have permission to merge, please do it 🚀 |
deansheather
reviewed
Sep 9, 2022
bpmct
approved these changes
Sep 11, 2022
Contributor
Author
|
After seeing @kylecarbs suggestion and talking with @bpmct I think having this icon the same as app icons is the best so it supports Icon URLs and we will upload some built-in icons. |
kylecarbs
approved these changes
Sep 12, 2022
deansheather
approved these changes
Sep 12, 2022
Co-authored-by: Kyle Carberry <kyle@carberry.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to coder/coder#3487