feat: add healthcheck parameters to coder_app #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
reviewed
Sep 21, 2022
Member
kylecarbs
left a comment
kylecarbs
left a comment
There was a problem hiding this comment.
I'll leave more comments in a bit, just didn't have time for a full review!
deansheather
approved these changes
Sep 21, 2022
kylecarbs
reviewed
Sep 21, 2022
deansheather
approved these changes
Sep 21, 2022
bpmct
reviewed
Sep 21, 2022
Member
bpmct
left a comment
bpmct
left a comment
There was a problem hiding this comment.
Huge fan of the schema. Seems like its exactly what we're looking for
kylecarbs
approved these changes
Sep 21, 2022
kylecarbs
approved these changes
Sep 22, 2022
Comment on lines
+390
to
+401
| "interval": { | ||
| Type: schema.TypeInt, | ||
| Description: "Duration in seconds to wait between healthcheck requests.", | ||
| ForceNew: true, | ||
| Required: true, | ||
| }, | ||
| "threshold": { | ||
| Type: schema.TypeInt, | ||
| Description: "Number of consecutive heathcheck failures before returning an unhealthy status.", | ||
| ForceNew: true, | ||
| Required: true, | ||
| }, |
Member
There was a problem hiding this comment.
One minor nit before merge, should we make these optional instead with reasonable defaults?
Also Kubernetes calls this period instead of interval. I'm impartial, just wanted to toss the idea up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocking coder/coder#4114