feat: Add shutdown_script_timeout
#96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
approved these changes
Feb 10, 2023
Member
mtojek
left a comment
mtojek
left a comment
There was a problem hiding this comment.
It's complimentary to the startup timeout, so 👍 .
| - `error` (String) An error message to display if the value doesn't match the provided regex. | ||
| - `max` (Number) The maximum of a number parameter. | ||
| - `min` (Number) The minimum of a number parameter. | ||
| - `monotonic` (String) Number monotonicity, either increasing or decreasing. |
Member
There was a problem hiding this comment.
👍
nit: we may want to improve the Makefile to detect discrepancies.
Member
Author
There was a problem hiding this comment.
This is done via make gen, we should probably verify in CI that there are no changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: coder/coder#6139