Skip to content

fix: patch isProposedAPIEnabled to always be true #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsjoeio merged 1 commit into from
Dec 17, 2021
Merged

fix: patch isProposedAPIEnabled to always be true #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/vs/workbench/services/extensions/common/extensions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,15 @@ export interface IExtensionHost {
}

export function isProposedApiEnabled(extension: IExtensionDescription, proposal: ApiProposalName): boolean {
if (!extension.enabledApiProposals) {
return false;
}
return extension.enabledApiProposals.includes(proposal);
/**
* The Jupyter extension uses proposed APIs
* but has a version that doesn't enable it correctly.
*
* This patch ensures that we default to enabling
* the proposed API.
* @author coder
*/
return true
}

export function checkProposedApiEnabled(extension: IExtensionDescription, proposal: ApiProposalName): void {
Expand Down