Improve memory display formatting #21
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| import { useState, useEffect } from 'react'; | ||
|
|
||
| interface AlertBarProps { | ||
| cpuUsage: number[]; | ||
| memPercent: number; | ||
| } | ||
|
|
||
| function getAlerts(cpuUsage: number[], memPercent: number): { message: string; level: 'info' | 'warn' | 'critical' }[] { | ||
| const alerts: { message: string; level: 'info' | 'warn' | 'critical' }[] = []; | ||
| const avgCpu = cpuUsage.reduce((a, b) => a + b, 0) / cpuUsage.length; | ||
|
|
||
|
Comment on lines
+8
to
+11
There was a problem hiding this comment. Handle empty CPU samples before averaging. At Line 10, dividing by 💡 Proposed fix- const avgCpu = cpuUsage.reduce((a, b) => a + b, 0) / cpuUsage.length;
+ const avgCpu =
+ cpuUsage.length > 0
+ ? cpuUsage.reduce((a, b) => a + b, 0) / cpuUsage.length
+ : 0;🤖 Prompt for AI Agents |
||
| if (avgCpu > 90) { | ||
| alerts.push({ message: 'CPU usage critical', level: 'critical' }); | ||
| } else if (avgCpu > 70) { | ||
| alerts.push({ message: 'CPU usage high', level: 'warn' }); | ||
| } | ||
|
|
||
| if (memPercent > 90) { | ||
| alerts.push({ message: 'Memory usage critical', level: 'critical' }); | ||
| } else if (memPercent > 70) { | ||
| alerts.push({ message: 'Memory usage high', level: 'warn' }); | ||
| } | ||
|
|
||
| if (alerts.length === 0) { | ||
| alerts.push({ message: 'All systems nominal', level: 'info' }); | ||
| } | ||
|
|
||
| return alerts; | ||
| } | ||
|
|
||
| export function AlertBar({ cpuUsage, memPercent }: AlertBarProps) { | ||
| const [visible, setVisible] = useState(true); | ||
| const alerts = getAlerts(cpuUsage, memPercent); | ||
| const hasWarnings = alerts.some((a) => a.level !== 'info'); | ||
|
|
||
| useEffect(() => { | ||
| if (!hasWarnings) return; | ||
| const interval = setInterval(() => { | ||
| setVisible((prev) => !prev); | ||
| }, 800); | ||
| return () => clearInterval(interval); | ||
| }, [hasWarnings]); | ||
|
|
||
| const highestLevel = alerts.reduce<'info' | 'warn' | 'critical'>((max, a) => { | ||
| const order = { info: 0, warn: 1, critical: 2 }; | ||
| return order[a.level] > order[max] ? a.level : max; | ||
| }, 'info'); | ||
|
|
||
| return ( | ||
| <div className={`alert-bar alert-${highestLevel} ${hasWarnings && !visible ? 'alert-flash-off' : ''}`}> | ||
| <span className="alert-icon"> | ||
| {highestLevel === 'critical' ? '!!' : highestLevel === 'warn' ? '!' : '~'} | ||
| </span> | ||
| <div className="alert-messages"> | ||
| {alerts.map((alert, i) => ( | ||
| <span key={i} className={`alert-msg alert-msg-${alert.level}`}> | ||
| {alert.message} | ||
| </span> | ||
| ))} | ||
| </div> | ||
| <span className="alert-timestamp"> | ||
| {new Date().toLocaleTimeString()} | ||
| </span> | ||
| </div> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: coderabbit-demo/btop
Length of output: 1174
Pass numeric CPU percentages into
AlertBar.At line 75,
metrics.cpuUsageisCpuUsage[]butAlertBarexpectsnumber[]. The component'sgetAlertsfunction will fail when it tries to compute the average with.reduce((a, b) => a + b, 0).Fix
📝 Committable suggestion
🤖 Prompt for AI Agents