[WIP] Add AGM view for users by Drewbi · Pull Request #1671 · codersforcauses/website

Drewbi · 2026-02-22T15:56:01Z

…estions

vercel · 2026-02-22T15:56:05Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
website	Error		Feb 22, 2026 3:56pm

Drewbi · 2026-02-22T15:58:44Z

.gitignore

+CLAUDE.md
+.CLAUDE
+.llms


Shout out to my homies

Drewbi · 2026-02-22T16:00:08Z

src/server/api/routers/general-meetings/sub-routes/positions/index.ts

+
+export const positionsInGeneralMeetingsRouter = createTRPCRouter({
+  get: getPositions,
+  getWithCounts: getPositionsWithCounts,


I think this can probably just be calculated from the returned candidates for a position

Drewbi · 2026-02-22T16:00:56Z

src/server/api/routers/general-meetings/sub-routes/positions/endpoints/get-with-counts.ts

+      .select({
+        ...getTableColumns(positions),
+        nomineeCount: count(nominations.candidateId),
+      })
+      .from(positions)
+      .leftJoin(nominations, eq(nominations.positionId, positions.id))
+      .where(eq(positions.meetingId, input.meetingId))
+      .groupBy(positions.id)
+      .orderBy(asc(positions.priority))


You reckon there would be a way to do this with query instead of select? Will probably delete this endpoint anyway

Drewbi · 2026-02-22T16:01:44Z

...r/api/routers/general-meetings/sub-routes/positions/endpoints/get-candidates-for-position.ts

+    if (!position) throw new TRPCError({ code: "NOT_FOUND", message: "Position not found" })
+
+    const positionNominations = await ctx.db
+      .select()


change to query

Drewbi · 2026-02-22T16:02:57Z

...r/api/routers/general-meetings/sub-routes/positions/endpoints/get-candidates-for-position.ts

+      questions: meetingQuestions,
+      candidates: candidateRows.map((candidate) => ({
+        ...candidate,
+        answers: allAnswers.filter((a) => a.candidateId === candidate.id),


This is BAD. Should really just include questions and answers in candidate query

Drewbi · 2026-02-22T16:03:21Z

src/server/api/routers/general-meetings/sub-routes/nominations/endpoints/get.ts

+const getNominations = publicRatedProcedure()
+  .input(z.object({ positionId: z.uuidv7() }))
+  .query(async ({ ctx, input }) => {
+    return ctx.db.select().from(nominations).where(eq(nominations.positionId, input.positionId))


Drewbi · 2026-02-22T16:03:26Z

src/server/api/routers/general-meetings/sub-routes/nominations/endpoints/get-by-candidate.ts

+const getNominationsByCandidate = publicRatedProcedure()
+  .input(z.object({ candidateId: z.uuidv7() }))
+  .query(async ({ ctx, input }) => {
+    return ctx.db.select().from(nominations).where(eq(nominations.candidateId, input.candidateId))


Drewbi · 2026-02-22T16:04:26Z

src/server/api/routers/general-meetings/sub-routes/candidates/endpoints/get.ts

+const getCandidates = publicRatedProcedure()
+  .input(z.object({ meetingId: z.uuidv7() }))
+  .query(async ({ ctx, input }) => {
+    return ctx.db.select().from(candidates).where(eq(candidates.meetingId, input.meetingId))


Drewbi · 2026-02-22T16:04:46Z

src/server/api/routers/general-meetings/sub-routes/candidates/endpoints/get-by-user.ts

+    const [candidate] = await ctx.db
+      .select()
+      .from(candidates)
+      .where(and(eq(candidates.meetingId, input.meetingId), eq(candidates.userId, ctx.session.user.id)))
+    return candidate ?? null


Drewbi · 2026-02-22T16:08:11Z

src/app/general-meetings/[slug]/meeting-page.tsx

+  const sameDay = meeting.end && meeting.start.toDateString() === meeting.end.toDateString()
+
+  return (
+    <main className="container mx-auto px-4 py-12">


I think this needs extra styles to work in light mode

Drewbi · 2026-02-22T16:08:37Z

src/app/general-meetings/[slug]/meeting-page.tsx

+          <h1 className="scroll-m-20 font-mono text-4xl tracking-tight text-balance">{meeting.title}</h1>
+          <div className="flex flex-col gap-1.5 font-mono text-sm text-neutral-500 dark:text-neutral-400">
+            <div className="flex items-center gap-2">
+              <span className="material-symbols-sharp text-base! leading-none!">schedule</span>


Lots of important usage here, not really sure why

material symbols jank and the styles don't work unless important

Drewbi · 2026-02-22T16:09:34Z

src/app/general-meetings/[slug]/meeting-page.tsx

+          </section>
+        )}
+
+        {(meeting.status === "upcoming" || meeting.status === "ongoing") && (


This allows them to access nominations page even when meeting is open. I think this is desired behaviour

Drewbi · 2026-02-22T16:10:15Z

src/app/general-meetings/[slug]/meeting-page.tsx

+          </section>
+        )}
+
+        {meeting.status === "ongoing" && (


Might need an else here to tell them to hang tight if the meeting hasn't opened yet

Drewbi · 2026-02-22T16:11:13Z

src/app/general-meetings/[slug]/layout.tsx

+      <Header />
+      {children}
+      <Footer />


Could probably put some of the general layout styles in this top level layout

Drewbi · 2026-02-22T16:12:43Z

src/app/general-meetings/[slug]/vote/vote-page.tsx

+          </ul>
+        )}
+
+        <p className="text-sm text-neutral-500 dark:text-neutral-400">Voting coming soon.</p>


Not sure how we want to handle which position is open for voting. Might need to add a property to the positions table

Drewbi · 2026-02-22T16:13:20Z

src/app/general-meetings/[slug]/positions/[positionId]/position-page.tsx

+  const key = `cfc-stars-${positionId}`
+  const [starred, setStarred] = React.useState<Set<string>>(new Set())


this is a non-essential feature but is kinda useful for remembering your favs before voting has opened

Drewbi · 2026-02-22T16:14:54Z

src/app/general-meetings/[slug]/nominate/nominate-form.tsx

+type Question = {
+  id: string
+  text: string
+  type: "short" | "long" | "checkbox" | null
+  required: boolean | null
+  order: number
+}


should this stuff be coming from tRPC?

Drewbi · 2026-02-22T16:15:25Z

src/app/general-meetings/[slug]/nominate/nominate-form.tsx

+    { enabled: !!myCandidate },
+  )
+
+  const [isEditing, setIsEditing] = React.useState(false)


do we really gotta preface React. all the time?

Yeah, it's the recommended way (by Dan Abramov)

Drewbi · 2026-02-22T16:16:31Z

src/app/general-meetings/[slug]/nominate/nominate-form.tsx

+        await Promise.all([
+          ...[...selectedPositions].map((positionId) =>
+            createNomination.mutateAsync({ meetingId: meeting.id, positionId, candidateId: candidate.id }),
+          ),
+          ...questions


this looks hella jank, lmk if theres a better way

I skimmed over this. Way too much to read on a PR

Drewbi · 2026-02-22T16:17:41Z

src/app/general-meetings/[slug]/nominate/nominate-form.tsx

+              {btnText}
+            </motion.span>
+          </AnimatePresence>
+          {loading && <Spinner className="absolute right-4" />}


This loading spinner is inside the text every time, gotta fix

Drewbi · 2026-02-22T16:19:05Z

src/app/dashboard/admin/general-meetings/[slug]/page.tsx

This probably has huge conflicts with your changes @JeremiahPinto, m'pologies

JeremiahPinto · 2026-02-25T11:50:30Z

src/app/dashboard/admin/general-meetings/[slug]/cards/agenda.tsx

+    setBtnText("Saving agenda")
+    startTransition(async () => {
+      try {
+        await updateMeeting.mutateAsync({ id: meetingId, agenda: agenda || null })


Should use mutate instead of mutateAsync if u're not using the values returned

JeremiahPinto · 2026-02-25T11:52:19Z

src/app/dashboard/admin/general-meetings/[slug]/cards/agenda.tsx


  return (
-    <form
-      className={cn("flex w-full flex-col gap-y-4 bg-white p-6 dark:bg-neutral-950", className)}


y remove this? it fixes accessibility focus with tanstack-form

I mean the next line. misclick hehe

JeremiahPinto

PR too chonk. Have a look at some of the comments

JeremiahPinto · 2026-02-25T11:54:21Z

src/app/dashboard/admin/general-meetings/[slug]/cards/agenda.tsx

-              )
-            }}
-          </form.Field>
+          <Textarea


why change this from uncontrolled to controlled. Will cause unnecessary re-renders

JeremiahPinto · 2026-02-25T11:56:11Z

src/app/dashboard/admin/general-meetings/[slug]/cards/status.tsx

+
+import * as React from "react"
+import { useParams } from "next/navigation"
+import { CalendarClock, CircleCheck, CircleX, LoaderCircle } from "lucide-react"


I'm trying to use material-symbols instead of lucide-icons

The dependency is left just to deal with shadcn cli

JeremiahPinto · 2026-02-25T11:59:34Z

src/app/dashboard/admin/general-meetings/[slug]/cards/status.tsx

+      <FieldSet>
+        <FieldLegend variant="label">Meeting status</FieldLegend>
+        <FieldDescription>Manually override the current meeting status.</FieldDescription>
+        <RadioGroup value={status} onValueChange={handleChange} disabled={loading} className="mt-1">


would prefer uncontrolled instead of controlled but not as big an issue

JeremiahPinto · 2026-02-25T12:01:45Z

src/app/dashboard/admin/sidebar/dialogs/create-meeting.tsx

    .max(nextFiveYears, "Date must be within the next five years"),
  start_time: z.iso.time({ precision: -1, error: "Start time is required" }),
-  venue: z.string(),
+  end_time: z.iso.time({ precision: -1, error: "End time is required" }),


This will conflict with mine, but I didn't want end time to be required coz agms always run overtime lol

JeremiahPinto · 2026-02-25T12:11:25Z

src/app/general-meetings/[slug]/nominate/nominate-form.tsx

+    { enabled: !!myCandidate },
+  )
+
+  const [isEditing, setIsEditing] = React.useState(false)


Yeah, it's the recommended way (by Dan Abramov)

JeremiahPinto · 2026-02-25T12:12:20Z

src/app/general-meetings/[slug]/nominate/nominate-form.tsx

+        await Promise.all([
+          ...[...selectedPositions].map((positionId) =>
+            createNomination.mutateAsync({ meetingId: meeting.id, positionId, candidateId: candidate.id }),
+          ),
+          ...questions


I skimmed over this. Way too much to read on a PR

JeremiahPinto · 2026-02-25T12:15:43Z

src/app/general-meetings/[slug]/meeting-page.tsx

+          <h1 className="scroll-m-20 font-mono text-4xl tracking-tight text-balance">{meeting.title}</h1>
+          <div className="flex flex-col gap-1.5 font-mono text-sm text-neutral-500 dark:text-neutral-400">
+            <div className="flex items-center gap-2">
+              <span className="material-symbols-sharp text-base! leading-none!">schedule</span>


material symbols jank and the styles don't work unless important

Drewbi added 7 commits February 22, 2026 23:46

fix meeting schema column names and foreign keys

7dab2ce

add @tailwindcss/typography

1cc4987

add default descriptions for positions

d6af9a7

add update/delete endpoints for admin general meetings, positions, qu…

82a8b11

…estions

add user-facing general meetings tRPC router

34e5bd0

update admin general meeting UI (cards, page, sidebar)

7b69db8

add user-facing general meetings pages (view, nominate, vote)

a236250

Drewbi commented Feb 22, 2026

View reviewed changes

.gitignore

Comment on lines +57 to +59

CLAUDE.md

.CLAUDE

.llms No newline at end of file

Copy link

Contributor Author

Drewbi Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shout out to my homies

Drewbi commented Feb 22, 2026

View reviewed changes

JeremiahPinto reviewed Feb 25, 2026

View reviewed changes

		const key = `cfc-stars-${positionId}`
		const [starred, setStarred] = React.useState<Set<string>>(new Set())

Conversation

Drewbi commented Feb 22, 2026

Uh oh!

vercel bot commented Feb 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Drewbi Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JeremiahPinto left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Drewbi Feb 22, 2026 •

edited

Loading