Skip to content

Fix: improve code-mirror accessibility (tab trap) #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imantsk merged 2 commits into from
Apr 14, 2026
Merged

Fix: improve code-mirror accessibility (tab trap) #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
697b15d
Fix: improve code-mirror accessibility
rami-elementor Apr 12, 2026
318dfa3
Fix: improve code-mirror accessibility
rami-elementor Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/js/components/EditMenu/SnippetForm/SnippetForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,15 +152,15 @@ const EditFormWrap: React.FC = () => {
<Notices placement="above-form" />

<EditForm className={editFormClassName({ snippet, isReadOnly, isExpanded })}>
<main className="snippet-form-upper">
<div className="snippet-form-upper">
<div className="snippet-name-wrapper">
<NameInput />
<SnippetTypeInput setIsUpgradeDialogOpen={setIsUpgradeDialogOpen} />
</div>

<CodeEditor {...{ isExpanded, setIsExpanded }} />
<ConditionsEditor />
</main>
</div>

<div className="snippet-form-lower">
<UpsellBanner />
Expand Down
7 changes: 6 additions & 1 deletion src/js/components/EditMenu/SnippetForm/fields/CodeEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,12 @@ const EditorTextarea: React.FC<EditorTextareaProps> = ({ textareaRef }) => {
const { snippet, setSnippet } = useSnippetForm()

return (
<div className="snippet-editor">
<div
className="snippet-editor"
role="application"
aria-label={__('Code editor', 'code-snippets')}
aria-description={__('In the editing area, the Tab key enters a tab character. To exit the code editor, press the Escape key and then the Tab key.', 'code-snippets')}
>
<textarea
ref={textareaRef}
id="snippet-code"
Expand Down
Loading