Skip to content

Fix: improve accessibility in welcome screen #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rami-elementor merged 1 commit into from
May 1, 2026
Merged

Fix: improve accessibility in welcome screen #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/js/components/WelcomeMenu/Changelog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ export const Changelog = () =>
target="_blank" rel="noreferrer"
>
{__('View changelog', 'code-snippets')}
<span className="screen-reader-text">
{__('(opens in a new tab)', 'code-snippets')}
</span>
</a>
</div>
<div className="code-snippets-changelog-entries">
Expand Down
19 changes: 17 additions & 2 deletions src/js/components/WelcomeMenu/WelcomeMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,13 @@ const HeroImage = () => {
rel="noopener noreferrer"
>
{__('Read more', 'code-snippets')}
<span className="screen-reader-text">
{__('(opens in a new tab)', 'code-snippets')}
</span>
</a>
</div>
<figure>
{!isImageLoaded && <div className="code-snippets-loading-spinner"></div>}
{!isImageLoaded && <div className="code-snippets-loading-spinner" aria-hidden="true"></div>}
<img
src={DATA?.hero.image_url}
alt={__('Latest news image', 'code-snippets')}
Expand All @@ -49,7 +52,16 @@ const Partners: React.FC<PartnersProps> = ({ partners }) =>
</figure>
<div className="code-snippets-header-wrapper">
<h3>{title}</h3>
<a href={follow_url} target="_blank" rel="noopener noreferrer" aria-label={sprintf( /* translators: %s: partner name. */ __('Visit %s', 'code-snippets'), title)}>
<a
href={follow_url}
target="_blank"
rel="noopener noreferrer"
aria-label={sprintf(
/* translators: %s: partner name. */
__('Visit %s (opens in a new tab)', 'code-snippets'),
title
)}
>
{__('Visit', 'code-snippets')}
</a>
</div>
Expand All @@ -76,6 +88,9 @@ const Articles: React.FC<ArticlesProps> = ({ articles }) =>
<p className="item-description">{description}</p>
<a href={follow_url} className="button button-secondary" target="_blank" rel="noopener noreferrer">
{__('Read more', 'code-snippets')}
<span className="screen-reader-text">
{__('(opens in a new tab)', 'code-snippets')}
</span>
</a>
</div>
</li>)}
Expand Down
Loading