Tooling: install the jsx-a11y plugin#377
Draft
rami-elementor wants to merge 9 commits intocore-betafrom
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds accessibility-focused tooling and checks to the Code Snippets repo by introducing JSX a11y linting rules, adding axe-core based Playwright accessibility tests, and wiring up a dedicated CI lint workflow.
Changes:
- Add
eslint-plugin-jsx-a11yto ESLint flat config and configure initial a11y rule severities. - Add
@axe-core/playwrightand a new Playwright E2E accessibility spec that runs axe against key admin screens. - Introduce a new GitHub Actions workflow to run CSS/JS/PHP linting on PRs and branch pushes.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
tests/e2e/accessibility.spec.ts |
New axe-core Playwright spec covering several WP admin/plugin screens. |
package.json |
Adds devDependencies for axe Playwright integration and eslint-plugin-jsx-a11y. |
package-lock.json |
Lockfile updates for the new devDependencies and transitive packages. |
eslint.config.mjs |
Enables jsx-a11y recommended flat config and adds explicit a11y rule severity overrides. |
.github/workflows/lint.yml |
New CI workflow intended to run stylelint, eslint, and PHP CS. |
Comment on lines
+38
to
+48
| - name: Install npm dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Run Stylelint | ||
| run: npm run lint:styles | ||
|
|
||
| - name: Run ESLint | ||
| run: npm run lint:js | ||
|
|
||
| - name: Run PHP CS | ||
| run: npm run lint:php |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.