Skip subdirectories of hidden directories

[DimitriPapadopoulos]

Fixes #2539.

[peternewman]

Heh, see also #2542 and #2543 too!

[DimitriPapadopoulos]

How do we proceed? Can I merge #2542 and #2543, then rebase and merge this merge request?

[larsoner]

@DimitriPapadopoulos CIs are not happy

[DimitriPapadopoulos]

Yes, after rebasing. Perhaps an issue with the CI tests themselves, I'll look into it.

[DimitriPapadopoulos]

The CIs were not happy because I did not expect --check-filenames to report the same misspelled directory multiple times, as many times as the files it contains:

$ mkdir mispelled
$ touch mispelled/file.txt
$ 
$ codespell --check-filenames --count
./mispelled/file.txt: mispelled ==> misspelled
1
$ 
$ mkdir mispelled/subdir1
$ touch mispelled/subdir1/file.txt
$ 
$ codespell --check-filenames --count
./mispelled/file.txt: mispelled ==> misspelled
./mispelled/subdir1/file.txt: mispelled ==> misspelled
2
$ 
$ mkdir mispelled/subdir2
$ touch mispelled/subdir2/file1.txt
$ touch mispelled/subdir2/file2.txt
$ touch mispelled/subdir2/file3.txt
$ 
$ codespell --check-filenames --count
./mispelled/file.txt: mispelled ==> misspelled
./mispelled/subdir2/file1.txt: mispelled ==> misspelled
./mispelled/subdir2/file2.txt: mispelled ==> misspelled
./mispelled/subdir2/file3.txt: mispelled ==> misspelled
./mispelled/subdir1/file.txt: mispelled ==> misspelled
5
$ 

This behaviour is not new. Perhaps it needs to be fixed, but then in a different PR. The reason is that codespell counts each pathname component for each file, even if that pathname component is shared by multiple files.

[DimitriPapadopoulos]

@larsoner Can you have a look?

[larsoner]

Thanks @DimitriPapadopoulos !