Skip to content

Check that we correctly handle nested hidden subdirectories #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peternewman wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Check that we correctly handle nested hidden subdirectories #2543

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e64c0c6
Add relative hidden directory tests
peternewman Oct 19, 2022
aa7bcd7
Test a hidden subdirectory too
peternewman Oct 19, 2022
c54a29a
Fix the expected typo numbers
peternewman Oct 19, 2022
b39020c
Recreate Dimitri's demo as a test
peternewman Oct 19, 2022
b34556c
Remove the broken tests for now
peternewman Oct 19, 2022
8057361
Check that we correctly handle nested hidden subdirectories
peternewman Oct 19, 2022
3b5a8f6
Merge branch 'master' into peternewman-hidden-subdir
peternewman Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions codespell_lib/tests/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,24 @@ def test_check_hidden(tmpdir, capsys):
assert cs.main(d) == 0
assert cs.main('--check-hidden', d) == 3
assert cs.main('--check-hidden', '--check-filenames', d) == 8
os.mkdir(op.join(d, '.abandonned', 'a'))
copyfile(op.join(d, '.abandonned.txt'),
op.join(d, '.abandonned', 'a', 'abandonned.txt'))
assert cs.main(d) == 0
assert cs.main('--check-hidden', d) == 4
assert cs.main('--check-hidden', '--check-filenames', d) == 11
os.mkdir(op.join(d, '.abandonned', 'a', 'b'))
copyfile(op.join(d, '.abandonned.txt'),
op.join(d, '.abandonned', 'a', 'b', 'abandonned.txt'))
assert cs.main(d) == 0
assert cs.main('--check-hidden', d) == 5
assert cs.main('--check-hidden', '--check-filenames', d) == 14
os.mkdir(op.join(d, '.abandonned', 'a', 'b', 'c'))
copyfile(op.join(d, '.abandonned.txt'),
op.join(d, '.abandonned', 'a', 'b', 'c', 'abandonned.txt'))
assert cs.main(d) == 0
assert cs.main('--check-hidden', d) == 6
assert cs.main('--check-hidden', '--check-filenames', d) == 17


def test_case_handling(tmpdir, capsys):
Expand Down