Skip to content

Test double escapes are skipped #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
peternewman wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Test double escapes are skipped #2880

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d05ea13
Test to check our string escape word triggers on its own
peternewman Jun 15, 2023
a2ae09c
Change to some words which ought to actually trigger codespell
peternewman Jun 15, 2023
46afe4a
Reorder tests so our counts of errors are correct
peternewman Jun 15, 2023
07f9023
Fix our error count and explain why
peternewman Jun 15, 2023
c94df74
Add a note about backslash escapes to the readme
peternewman Jun 15, 2023
3f80381
Force GitHub format so ruff auto-annotates
peternewman Jun 15, 2023
817cfa8
Fix a lint error
peternewman Jun 15, 2023
ed909bf
Test double escapes are skipped
peternewman Jun 15, 2023
1a2dec4
Merge branch 'master' into peternewman-string-double-escape
peternewman Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions codespell_lib/tests/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,11 @@ def test_basic(
with fname.open("w") as f: # overwrite the file
f.write("var = '\\nwe must check codespell likes escapes \\nin strings'\n")
assert cs.main(fname) == 0, "with string escape"
with fname.open("w") as f: # overwrite the file
f.write("var = '\\\\nwe must check codespell ignores double escapes \\\\nin strings'\n")
assert cs.main(fname) == 2, "with string escape"
# the four backslashes here become two on disk and one when output to a file,
# so these typos should be found
result = cs.main(fname, "--builtin", "foo", std=True)
assert isinstance(result, tuple)
code, _, stderr = result
Expand Down