Skip to content

Conversation

@DanielYang59
Copy link
Contributor

@DanielYang59 DanielYang59 commented Nov 21, 2024

Follow up #3580 (comment).


Question:

@DimitriPapadopoulos
Copy link
Collaborator

DimitriPapadopoulos commented Nov 21, 2024

dictionary_names.txt is the same as other dictionaries: it contains potential typos with corrections.

In this case, the potential typos are valid proper nouns (names).

@DanielYang59
Copy link
Contributor Author

Hi @DimitriPapadopoulos thanks for your comment.

it contains potential typos with corrections.
In this case, the potential typos are valid proper nouns (names).

I still don't really understand the behaviour, should I expect a word in my target file like Liszt to be marked as typo or not? In my case codespell doesn't seem to flag Liszt as typo, if so why do we need this dictionary? For optional functionality maybe?

@DimitriPapadopoulos
Copy link
Collaborator

This dictionary is not part of the default dictionaries.

@DanielYang59 DanielYang59 marked this pull request as ready for review November 22, 2024 14:43
@DanielYang59
Copy link
Contributor Author

okay thanks for the reply

@DanielYang59
Copy link
Contributor Author

Can you look into this please? @larsoner @peternewman

@larsoner
Copy link
Member

Marking for merge-when-green, thanks in advance @DanielYang59 !

@DanielYang59
Copy link
Contributor Author

No worries at all, thanks for reviewing :)

@DanielYang59
Copy link
Contributor Author

@larsoner Maybe forgot to trigger auto-merge?

@larsoner larsoner merged commit 8a42885 into codespell-project:main Jan 30, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants