List of typos fixed in LibreOffice by Gelma · Pull Request #428 · codespell-project/codespell

Gelma · 2018-04-01T16:57:28Z

This is the list of words fixed in LibreOffice.
It's a specific list, so I guess it's better if
you check word by word.

I purged words already present in all the history
of CodeSpell dictionary (to avoid to re-insert words
removed before, for any reason).

This is the list of words fixed in LibreOffice. It's a specific list, so I guess it's better if you check word by word. I purged words already present in *all* the history of CodeSpell dictionary (to avoid to re-insert words removed before, for any reason).

codecov-io · 2018-04-01T17:02:09Z

Codecov Report

Merging #428 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   87.81%   87.81%           
=======================================
  Files           2        2           
  Lines         665      665           
  Branches       93       93           
=======================================
  Hits          584      584           
  Misses         62       62           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be48f1f...9669566. Read the comment docs.

Started to separate codespell-project#428 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise. This PR has been sorted as well.

Continue to separate codespell-project#428 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise. This PR has been sorted as well.

luzpaz · 2018-04-02T02:10:52Z

@Gelma
What's the LO license ?

fitojb · 2018-04-02T06:30:01Z

LibreOffice’s source code is licensed under the Mozilla Public License 2.0, with portions under the Apache License 2.0.

luzpaz · 2018-04-02T10:18:24Z

codespell_lib/data/dictionary_from_LO.txt

+asynchrounous->asynchronous
+asynchrounsly->asynchronously
+asynschron->asynchronous
+atemptively->attemptively


I don't think this is a valid word

luzpaz · 2018-04-02T10:19:43Z

codespell_lib/data/dictionary_from_LO.txt

+apllicatin->application
+apllication->application
+appedn->append
+appendent->appendend


This is incorrect. Should be appended.
I've removed this in #430

luzpaz · 2018-04-02T10:20:23Z

codespell_lib/data/dictionary_from_LO.txt

+acessor->accessor
+achor->Anchor
+ACII->ASCII
+Acitivate->Activate


should be lowercase, fixed in #430

luzpaz · 2018-04-02T10:21:42Z

codespell_lib/data/dictionary_from_LO.txt

+autocoomit->autocommit
+autofilt->autofilter
+autofomat->autoformat
+autogrowwith->autogrowwidth


not sure we should add this

There are a lot of specific words just for LO.

That's the reason I didn't merge directly, but let other decide about what to exclude.

luzpaz · 2018-04-02T10:22:05Z

codespell_lib/data/dictionary_from_LO.txt

+bage->bag
+baisc->basic
+balacing->balancing
+ballonmode->balloonmode


luzpaz · 2018-04-02T10:23:01Z

codespell_lib/data/dictionary_from_LO.txt

+basci->basic
+basf->base
+basicmanger->basicmanager
+basidide->basicide


This doesn't seem relevant either. basic ide ?

luzpaz · 2018-04-02T10:29:18Z

codespell_lib/data/dictionary_from_LO.txt

+breakes->breaks
+brfore->before
+brigthness->brightness
+bringtofont->bringtofront


should this be kept in ?

luzpaz · 2018-04-02T10:30:41Z

codespell_lib/data/dictionary_from_LO.txt

+carryintg->carrying
+caseingore->caseignore
+caseinlie->caseinline
+case-insenstive->case-insensitive


wonder why this one is hyphenated where most of the other multi-words (see directly above and below) aren't

This list if made of words found in the LO sources.

So, as I found 'em, I recorded.

luzpaz · 2018-04-02T10:32:15Z

codespell_lib/data/dictionary_from_LO.txt

+cellxs->cells
+centain->certain
+centerd->centered
+centimetres->centimeters


centimetres is a valid European spelling. We've removed and metre words from dictionary.txt because of this.

Funny.
I parsed all the git history of CodeSpell to avoid to re-insert something already removed.

Gelma · 2018-04-02T11:34:36Z

@luzpaz
I don't see problem for the license.

These are the typo that I manually fixed inside LO. Just words.

arm-in · 2018-04-02T11:57:26Z

codespell_lib/data/dictionary_from_LO.txt

+alloced->allocated
+alloed->allowed
+allowe->allowed
+alls->all


could be "falls"

@arm-in I can add your suggestions to #430

Hi, it's not wrong (but I understand if you don't want include for general purpose)

I found - always in LO - senteces like "alls the bullets" and so on.

added in #430

arm-in · 2018-04-02T11:58:20Z

codespell_lib/data/dictionary_from_LO.txt

+alignmen->alignment
+alignmnet->alignment
+alising->aliasing
+aliver->alive


could be "liver" (for whatever reason)

arm-in · 2018-04-02T11:58:36Z

codespell_lib/data/dictionary_from_LO.txt

+alignmnet->alignment
+alising->aliasing
+aliver->alive
+alled->called


could be "allied"

Yeppa, also here it was exactly a missing "c" (I repeat, this is LO specific. It makes sense to avoid it for general case)

arm-in · 2018-04-02T11:58:56Z

codespell_lib/data/dictionary_from_LO.txt

+aliver->alive
+alled->called
+alloced->allocated
+alloed->allowed


could be "allied"

luzpaz · 2018-04-02T14:46:07Z

codespell_lib/data/dictionary_from_LO.txt

+contnt->content
+contolls->controls
+contols->controls
+contorls->conrtols


luzpaz · 2018-04-02T14:52:49Z

codespell_lib/data/dictionary_from_LO.txt

+combind->combined
+comilers->compilers
+commen->comment
+commens->comments


This is a legit word. But obsolete AFAICT

luzpaz · 2018-04-02T14:59:06Z

codespell_lib/data/dictionary_from_LO.txt

+wronf->wrong
+wuold->would
+xdpf->xpdf
+xelementacces->xelementaccess


not relevant, IMO

luzpaz · 2018-04-02T14:59:23Z

codespell_lib/data/dictionary_from_LO.txt

+Yugoslac->Yugoslav
+ziped->zipped
+zlot->slot
+zuser->user


luzpaz · 2018-04-02T15:03:16Z

@Gelma thank you for submitting this. I acknowledge the work it took.

Couple of things, I think we're going to merge it in to the codespell dictionary.txt and therefore it needs to be submit in easily reviewable chunks. In the past I've done one letter at a time in alphabetical order. I've started on a an b already as you can see (c is currently being worked on).

Gelma · 2018-04-02T22:30:59Z

@luzpaz
Thanks a lot for your review.

I would like you complete it. Better two more eyes.

Gelma · 2018-04-03T12:03:15Z

@arm-in @luzpaz
Thanks a lot to both for the review.

I included in my file. Now I push a new version with also the rest of the fixes.

Started to separate codespell-project#428 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise. This PR has been sorted as well.

Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

* Letter 'i' from #436 Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. * Follow-up fixes * Revised per feedback * fixed broken entry * More dupe fixes * removed dupe * remove another dupe

* Letter 'q' from #436 Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. * Update dictionary.txt

Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

* Letter 'u' from #436 Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. * removed and merged dupe * removed another dupe * merged and removed dupe * Add additional suggested results

* Letter 'v' from #436 Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. * Added suggested additional result

* Letter ''w, x, y, and z' from #436 Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. * Added suggested additional entries

Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

* Letter 't' from #436 Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. * Removed dupe * Removed another dupe * Added suggestions

Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. Note: please review closely

Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

* Letter 'p' from #436 Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. * Added suggested entry results

Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. Note: please review closely

Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. Note: please review closely

* Letter 'r' from #436 Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. Note: please review closely * removed dupe * Added requested revisions

Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

* Letter 's' from #436 Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. * Added specialy->specially * removed dupe * removed another dupe * Added requested revisions

luzpaz mentioned this pull request Apr 2, 2018

Letter 'a' from #428 #430

Closed

luzpaz mentioned this pull request Apr 2, 2018

Letter 'b' from #428 #431

Merged

luzpaz reviewed Apr 2, 2018

View reviewed changes

codespell_lib/data/dictionary_from_LO.txt

bage->bag

baisc->basic

balacing->balancing

ballonmode->balloonmode

Copy link

Collaborator

luzpaz Apr 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or this...

luzpaz reviewed Apr 2, 2018

View reviewed changes

arm-in reviewed Apr 2, 2018

View reviewed changes

codespell_lib/data/dictionary_from_LO.txt

aliver->alive

alled->called

alloced->allocated

alloed->allowed

Copy link

Contributor

arm-in Apr 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be "allied"

luzpaz reviewed Apr 2, 2018

View reviewed changes

codespell_lib/data/dictionary_from_LO.txt

wronf->wrong

wuold->would

xdpf->xpdf

xelementacces->xelementaccess

Copy link

Collaborator

luzpaz Apr 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant, IMO

luzpaz reviewed Apr 2, 2018

View reviewed changes

codespell_lib/data/dictionary_from_LO.txt

Yugoslac->Yugoslav

ziped->zipped

zlot->slot

zuser->user

Copy link

Collaborator

luzpaz Apr 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relevant?

luzpaz mentioned this pull request May 9, 2018

Letter 'u' from #436 #503

Merged

luzpaz mentioned this pull request May 9, 2018

Letter 'v' from #436 #504

Merged

luzpaz mentioned this pull request May 9, 2018

Letter ''w, x, y, and z' from #436 #505

Merged

Conversation

Gelma commented Apr 1, 2018

Uh oh!

codecov-io commented Apr 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

luzpaz commented Apr 2, 2018

Uh oh!

fitojb commented Apr 2, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Gelma commented Apr 2, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luzpaz commented Apr 2, 2018

Uh oh!

Gelma commented Apr 2, 2018

Uh oh!

Gelma commented Apr 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov-io commented Apr 1, 2018 •

edited

Loading