Conversation
neSpecc
requested review from
TatianaFomina,
gohabereg and
ilyamore88
as code owners
ilyamore88
approved these changes
Oct 22, 2023
gohabereg
approved these changes
Oct 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If user enables Content Security Policy style-src, editor's styles are not working
Cause
If CSP "style-src" enabled, browser will execute style only if:
Content-Security-Policy: style-src 'unsafe-inline'— bad solutionContent-Security-Policy: style-src 'sha256-ozBpjL6dxO8fsS4u6fwG1dFDACYvpNxYeBA6tzR+FY8='— user have to manually update hash on every editor style changeContent-Security-Policy: style-src 'nonce-2726c7f26c'— nonce is random number re-generated on each requestSolution
If user enabled CSP, he should generate random nonce on each request, set it in CSP header
Content-Security-Policy: style-src 'nonce-2726c7f26c'and pass it to the Editor, so we will add that nonce to the style tag.Resolves #1334