feat: add logs to domain services#301
Open
7eliassen wants to merge 9 commits intochore/logs-and-optimizationfrom
Open
feat: add logs to domain services#3017eliassen wants to merge 9 commits intochore/logs-and-optimizationfrom
7eliassen wants to merge 9 commits intochore/logs-and-optimizationfrom
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
e11sy
reviewed
Apr 9, 2026
| * Implementations are provided by the infrastructure layer | ||
| */ | ||
|
|
||
| export interface DomainLogger { |
Member
There was a problem hiding this comment.
domain server shared space was designed as a place, where you declare methods of actual domain, that could be used by other domains
i think that the DomainLogger should be moved to infrastructure/logging/, since it does not really belongs here
(check readme inside of the domain/service/shared)
Comment on lines
+27
to
+32
| const cachedLogger = loggerCache.get(moduleName); | ||
|
|
||
| if (cachedLogger) { | ||
| return cachedLogger; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
seems like a part of different PR, should this branch be rebased?
Author
There was a problem hiding this comment.
I changed the base branch to chore/logs-and-optimization
neSpecc
reviewed
Apr 10, 2026
|
Thanks for adding a description — the PR is now marked as Ready for Review. |
neSpecc
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add request-scoped business event logging to domain services.
domainmodule nameDomainLogerinterface to keep domain layer decoupled from infrastructure logging implementation. That preserve clean architecture.PinoDomainLoggerAdapterthat implementsDomainLoggerDomainErrorhandler to include reqId anddomainmodule name in logs