Merged
Conversation
Also moves rcfile loading to worm.nim rather than events.nim, which feels more sensible.
Owner
|
Looks good to me, thanks for all the PRs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also moves rcfile loading to worm.nim rather than events.nim, which feels more sensible.
I kept this simple and used
std/parseoptbecause I didn't really want to pull in a dependency for command-line parsing since you weren't using one inwormc, but if using something more robust would be preferred I can do that instead (this is also why I only added a long opt and not a short one, since parseopt usage is quite verbose).