Change defaults and documentation to use AARRGGBB#61
Merged
codic12 merged 4 commits intocodic12:mainfrom Apr 10, 2022
Merged
Conversation
added 4 commits
April 9, 2022 20:36
Plus some added features, I may have gone overboard on this in setting up contrast based on perceptual luminance
Owner
|
Looks good to me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60.
It was only when I was finishing up working on this that I finally noticed the note in the documentation about AARRGGBB, oops!
Regardless, that note doesn't indicate that there will be errors if not using RRGGBB and there's no real reason to hold-over on that format (including setting defaults with it) if it's going to cause issues when users use worm with the most popular compositor.
I went a bit overboard with reimplementing the pywal bit in the example rcfile, but it bothered me that when I tested it the foreground text colors would have to be set manually to maintain contrast.