Add active/inactive variants of {close,maximize,minimize}-path#70
Merged
codic12 merged 2 commits intocodic12:mainfrom Apr 13, 2022
Merged
Conversation
added 2 commits
April 12, 2022 10:49
Owner
|
Looks good to me! Thanks, I'll work on adding support for hovered buttons tomorrow a bit. |
Owner
|
Ok, so this might just be an issue with my current setup - certainly a really weird one but I think it is. For some reason, both before and after this PR I think, moving windows around after you set the close-active-path is very laggy, in Xephyr and the native X server. Do you have this issue? I presume not, and opensuse is just being weird with x11 somehow... I definitely wasn't having this issue on my other arch system. |
Contributor
Author
|
No, I don't have any notable issues, sorry. |
Owner
|
Also, in order to not break compatibility, I plan to re-add after all this is implemented close/minimize/maximize-path, which just sets all the states to the same value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{close,maximize,minimize}-path->{close,maximize,minimize}-{active,inactive}-pathI chose to go ahead and set up a ButtonState enum and change the config options to enum indexed arrays, since there's discussion in #57 about extending the possible states further.
Note that while I haven't implemented it in this PR in the interest of doing one thing at a time, it may be reasonable to get rid of ButtonState and instead have just a FocusState (or
focusedboolean value, if you're not concerned about the type system insurance from using a dedicated enum I suppose) on each client and moving every active/inactive switched value to be anarray[FocusState, t]wheretis their type. Then when adding hover states you could just have the button paths' config types bearray[FocusState, array[HoverState, string]].